Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/2246 fixed from field #2247

Merged
merged 6 commits into from
Mar 13, 2019
Merged

Fabo/2246 fixed from field #2247

merged 6 commits into from
Mar 13, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Mar 13, 2019

Closes #2246

Description:

Thank you! 🚀


For contributor:

  • Added entries in PENDING.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #2247 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2247   +/-   ##
========================================
  Coverage    96.63%   96.63%           
========================================
  Files          109      109           
  Lines         2316     2316           
  Branches       116      116           
========================================
  Hits          2238     2238           
  Misses          65       65           
  Partials        13       13
Impacted Files Coverage Δ
...ponents/transactions/LiDistributionTransaction.vue 85.71% <ø> (ø) ⬆️

Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping things up-to-date is more time consuming than should..maybe we need some external-internal mapping to have a single place where we populate stuff and that's the only interface to change when SDK changed stuff

@sabau sabau merged commit 6b6966d into develop Mar 13, 2019
@sabau sabau deleted the fabo/2246-missing-withdraw-from branch March 13, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Withdraw rewards transactions show empty "From" field
3 participants