Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/2228 display vesting accounts #2268

Merged
merged 5 commits into from
Mar 15, 2019
Merged

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Mar 14, 2019

Part of #2228

Description:

Simple version where we display the coins as normal coins. This is the lease code change (more like a bugfix). We can think about adding more vesting info later.

Thank you! 🚀


For contributor:

  • Added entries in PENDING.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

PENDING.md Show resolved Hide resolved
app/src/renderer/connectors/api.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #2268 into develop will decrease coverage by 0.12%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           develop    #2268      +/-   ##
===========================================
- Coverage    96.68%   96.56%   -0.13%     
===========================================
  Files          108      108              
  Lines         2321     2326       +5     
  Branches       115      115              
===========================================
+ Hits          2244     2246       +2     
- Misses          65       68       +3     
  Partials        12       12
Impacted Files Coverage Δ
app/src/renderer/connectors/api.js 94.91% <50%> (-5.09%) ⬇️

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #2268 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2268      +/-   ##
===========================================
+ Coverage    96.73%   96.74%   +0.01%     
===========================================
  Files          106      106              
  Lines         2296     2304       +8     
  Branches       116      116              
===========================================
+ Hits          2221     2229       +8     
  Misses          63       63              
  Partials        12       12
Impacted Files Coverage Δ
app/src/renderer/connectors/api.js 100% <100%> (ø) ⬆️

jbibla
jbibla previously approved these changes Mar 14, 2019
@fedekunze
Copy link
Contributor

@faboweb how do I test this ?

@faboweb
Copy link
Collaborator Author

faboweb commented Mar 14, 2019

@faboweb how do I test this ?

go mainnet with #2263 (which is merged now)

or test with: ?rpc=https://rpc.nylira.net:443&stargate=https://lcd.nylira.net#/

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove photino and stake:

Screen Shot 2019-03-14 at 11 12 50 PM

I'd also display that the type of account (Basic, Vesting) and state explicitly that the uatoms displayed are unlocked on this PR are unlocked (if vesting account)

@faboweb
Copy link
Collaborator Author

faboweb commented Mar 15, 2019

@fedekunze

Simple version where we display the coins as normal coins. This is the lease code change (more like a bugfix). We can think about adding more vesting info later.

fedekunze
fedekunze previously approved these changes Mar 15, 2019
@fedekunze fedekunze dismissed stale reviews from jbibla and themself via 65881e6 March 15, 2019 10:37
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedekunze fedekunze merged commit 510ea15 into develop Mar 15, 2019
@colw colw deleted the fabo/2228-vesting-accounts branch June 20, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants