Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/ Persist session type if signed in with ledger #2269

Merged
merged 6 commits into from
Mar 15, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Mar 14, 2019

The type was not persisted which caused the actionmodal on refresh not to show signing with ledger.

Description:

Thank you! 🚀


For contributor:

  • Added entries in PENDING.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #2269 into develop will decrease coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2269      +/-   ##
===========================================
- Coverage    96.73%   96.68%   -0.05%     
===========================================
  Files          106      108       +2     
  Lines         2296     2323      +27     
  Branches       116      115       -1     
===========================================
+ Hits          2221     2246      +25     
- Misses          63       65       +2     
  Partials        12       12
Impacted Files Coverage Δ
app/src/renderer/components/common/ActionModal.vue 100% <100%> (ø) ⬆️
app/src/renderer/vuex/modules/session.js 100% <100%> (ø) ⬆️
.../src/renderer/components/staking/PageValidator.vue 100% <0%> (ø) ⬆️
app/src/renderer/components/common/ToolBar.vue 100% <0%> (ø) ⬆️
app/src/renderer/components/common/Page404.vue 100% <0%> (ø) ⬆️
app/src/renderer/components/common/TmField.vue 100% <0%> (ø) ⬆️
...src/renderer/components/common/PagePreferences.vue 100% <0%> (ø)
app/src/renderer/vuex/modules/onboarding.js 84.61% <0%> (ø)
app/src/renderer/vuex/getters.js 90.74% <0%> (+0.17%) ⬆️

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #2269 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2269      +/-   ##
===========================================
+ Coverage    96.74%   96.74%   +<.01%     
===========================================
  Files          106      106              
  Lines         2304     2306       +2     
  Branches       116      116              
===========================================
+ Hits          2229     2231       +2     
  Misses          63       63              
  Partials        12       12
Impacted Files Coverage Δ
app/src/renderer/components/common/ActionModal.vue 100% <100%> (ø) ⬆️
app/src/renderer/vuex/modules/session.js 100% <100%> (ø) ⬆️

jbibla
jbibla previously approved these changes Mar 14, 2019
Copy link
Collaborator

@jbibla jbibla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW NICE

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ yarn start 
yarn run v1.13.0
$ concurrently -k "yarn frontend" "yarn backend"
$ cross-env NODE_ENV=development FAUCET='http://localhost:8080' webpack-dev-server --hot --colors --config webpack.renderer.config.js --port 9080 --content-base app/dist --https --mode=development
$ concurrently -k "yarn yarn connect" "yarn nodes 2 skip-rebuild"
$ node ./tasks/local-testnet/start.js 2 skip-rebuild
error Command "yarn" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[1] [0] yarn yarn connect exited with code 1

@jbibla
Copy link
Collaborator

jbibla commented Mar 15, 2019

@fedekunze it broke somewhere else

#2277

jbibla
jbibla previously approved these changes Mar 15, 2019
@fedekunze fedekunze merged commit 15a6a28 into develop Mar 15, 2019
@fedekunze fedekunze deleted the fabo/persist-ledger-session-type branch March 15, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants