-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fabo/ Persist session type if signed in with ledger #2269
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2269 +/- ##
===========================================
- Coverage 96.73% 96.68% -0.05%
===========================================
Files 106 108 +2
Lines 2296 2323 +27
Branches 116 115 -1
===========================================
+ Hits 2221 2246 +25
- Misses 63 65 +2
Partials 12 12
|
Codecov Report
@@ Coverage Diff @@
## develop #2269 +/- ##
===========================================
+ Coverage 96.74% 96.74% +<.01%
===========================================
Files 106 106
Lines 2304 2306 +2
Branches 116 116
===========================================
+ Hits 2229 2231 +2
Misses 63 63
Partials 12 12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WOW NICE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ yarn start
yarn run v1.13.0
$ concurrently -k "yarn frontend" "yarn backend"
$ cross-env NODE_ENV=development FAUCET='http://localhost:8080' webpack-dev-server --hot --colors --config webpack.renderer.config.js --port 9080 --content-base app/dist --https --mode=development
$ concurrently -k "yarn yarn connect" "yarn nodes 2 skip-rebuild"
$ node ./tasks/local-testnet/start.js 2 skip-rebuild
error Command "yarn" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[1] [0] yarn yarn connect exited with code 1
@fedekunze it broke somewhere else |
The type was not persisted which caused the actionmodal on refresh not to show signing with ledger.
Description:
Thank you! 🚀
For contributor:
PENDING.md
with issue # and GitHub usernameFiles changed
in the github PR explorerFor reviewer: