Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jordan/2267+2278 validator table bugs #2294

Closed
wants to merge 4 commits into from
Closed

Jordan/2267+2278 validator table bugs #2294

wants to merge 4 commits into from

Conversation

jbibla
Copy link
Collaborator

@jbibla jbibla commented Mar 15, 2019

Closes #2267
Closes #2278

Description:

  • fixed sorting on validator table
  • cleaned up data on li validator

Thank you! 🚀

For contributor:

  • Added entries in PENDING.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

fedekunze
fedekunze previously approved these changes Mar 15, 2019
View reviewed changes
@jbibla
Copy link
Collaborator Author

jbibla commented Mar 15, 2019

@sabau any idea what happened here? only 3 checks?

@jbibla
Copy link
Collaborator Author

jbibla commented Mar 16, 2019

going to close this and re-open - hoping not to break the CI next time 😆

@jbibla jbibla closed this Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze left review comments

@faboweb faboweb Awaiting requested review from faboweb faboweb is a code owner

@sabau sabau Awaiting requested review from sabau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commission Percentage is incorrect Sorting on validators do not work
2 participants
@jbibla @fedekunze