Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jordan/2267+2278 validator table bugs #2300

Merged
merged 17 commits into from
Mar 18, 2019
Merged

Jordan/2267+2278 validator table bugs #2300

merged 17 commits into from
Mar 18, 2019

Conversation

jbibla
Copy link
Collaborator

@jbibla jbibla commented Mar 16, 2019 •
edited by faboweb
Loading

Closes #2267
Closes #2278
Closes #2237

Description:

Thank you! 🚀

For contributor:

  • Added entries in PENDING.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Mar 16, 2019

Codecov Report

Merging #2300 into develop will decrease coverage by 0.18%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #2300      +/-   ##
===========================================
- Coverage    96.76%   96.58%   -0.19%     
===========================================
  Files          106      106              
  Lines         2318     2312       -6     
  Branches       117      117              
===========================================
- Hits          2243     2233      -10     
- Misses          63       66       +3     
- Partials        12       13       +1
Impacted Files Coverage Δ
...pp/src/renderer/components/staking/LiValidator.vue 73.91% <ø> (-16.09%) ⬇️
.../src/renderer/components/staking/PageValidator.vue 100% <ø> (ø) ⬆️
...rc/renderer/components/staking/TableValidators.vue 90.9% <0%> (-4.33%) ⬇️

@codecov
Copy link

codecov bot commented Mar 16, 2019 •
edited
Loading

Codecov Report

Merging #2300 into develop will increase coverage by 0.14%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop   #2300      +/-   ##
==========================================
+ Coverage    96.76%   96.9%   +0.14%     
==========================================
  Files          106     106              
  Lines         2318    2297      -21     
  Branches       117     113       -4     
==========================================
- Hits          2243    2226      -17     
+ Misses          63      62       -1     
+ Partials        12       9       -3
Impacted Files Coverage Δ
.../src/renderer/components/staking/PageValidator.vue 100% <ø> (ø) ⬆️
app/src/renderer/vuex/modules/delegates.js 97.91% <ø> (-0.2%) ⬇️
...pp/src/renderer/components/staking/LiValidator.vue 100% <100%> (+10%) ⬆️
app/src/renderer/vuex/modules/delegation.js 91.52% <100%> (+0.14%) ⬆️
...rc/renderer/components/staking/TableValidators.vue 100% <100%> (+4.76%) ⬆️

@jbibla jbibla changed the title Jordan/2267+2278 validator table bugs WIP: Jordan/2267+2278 validator table bugs Mar 17, 2019
@jbibla jbibla changed the title WIP: Jordan/2267+2278 validator table bugs Jordan/2267+2278 validator table bugs Mar 18, 2019
jbibla
jbibla commented Mar 18, 2019
View reviewed changes
app/src/renderer/components/staking/TableValidators.vue Outdated
},
enrichedDelegates() {
return this.validators.map(v =>
enrichedValidators({
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be happening somewhere else / refactored (#1380 #2306) but moving it would be a big task so i just made sure it worked and was tested... because previously it didn't work and wasn't tested.

fedekunze
fedekunze reviewed Mar 18, 2019
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need to test it manually

faboweb
faboweb reviewed Mar 18, 2019
View reviewed changes
test/unit/specs/components/staking/__snapshots__/LiValidator.spec.js.snap Outdated

<td
class="li-validator__commission"
>

0.05%
500.00%
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a lot ^^

@faboweb faboweb mentioned this pull request Mar 18, 2019
Closed
fedekunze
fedekunze approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ack

@fedekunze fedekunze merged commit 98331b6 into develop Mar 18, 2019
@fedekunze fedekunze deleted the jordan/2267+2278-validator-table-bugs branch March 18, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faboweb faboweb faboweb approved these changes

@fedekunze fedekunze fedekunze approved these changes

@sabau sabau Awaiting requested review from sabau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commission Percentage is incorrect Sorting on validators do not work TmPage "managed-body" refactor
3 participants
@jbibla @faboweb @fedekunze