Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/2303 balance display as whole #2322

Merged
merged 4 commits into from
Mar 20, 2019
Merged

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Mar 20, 2019

Closes #2303

Description:

Thank you! 🚀


For contributor:

  • Added entries in PENDING.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #2322 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2322      +/-   ##
===========================================
- Coverage    96.91%   96.89%   -0.02%     
===========================================
  Files          105      106       +1     
  Lines         2304     2290      -14     
  Branches       117      116       -1     
===========================================
- Hits          2233     2219      -14     
- Misses          61       62       +1     
+ Partials        10        9       -1
Impacted Files Coverage Δ
app/src/renderer/components/common/TmBalance.vue 100% <100%> (ø) ⬆️
app/src/renderer/components/wallet/SendModal.vue 85.29% <0%> (-2.59%) ⬇️
...ponents/transactions/LiDistributionTransaction.vue 85.71% <0%> (-1.79%) ⬇️
...rer/components/staking/ModalWithdrawAllRewards.vue 90.9% <0%> (-0.76%) ⬇️
...c/renderer/components/staking/TabMyDelegations.vue 95.83% <0%> (-0.17%) ⬇️
...rc/renderer/components/governance/PageProposal.vue 97.67% <0%> (-0.06%) ⬇️
...erer/components/transactions/LiBankTransaction.vue 100% <0%> (ø) ⬆️
...rer/components/transactions/LiStakeTransaction.vue 100% <0%> (ø) ⬆️
...rc/renderer/components/staking/DelegationModal.vue 92.59% <0%> (ø) ⬆️
app/src/renderer/vuex/store.js 100% <0%> (ø) ⬆️
... and 11 more

@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #2322 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2322      +/-   ##
===========================================
+ Coverage    97.11%   97.11%   +<.01%     
===========================================
  Files          105      105              
  Lines         2322     2326       +4     
  Branches       123      127       +4     
===========================================
+ Hits          2255     2259       +4     
  Misses          57       57              
  Partials        10       10
Impacted Files Coverage Δ
app/src/renderer/components/common/TmBalance.vue 100% <100%> (ø) ⬆️

fedekunze
fedekunze previously approved these changes Mar 20, 2019
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK

fedekunze
fedekunze previously approved these changes Mar 20, 2019
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK

@faboweb faboweb merged commit db3c32d into develop Mar 20, 2019
@faboweb faboweb deleted the fabo/2303-balance-display-as-whole branch March 20, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

on refresh, balance header shows incorrect numbers
2 participants