fix validator anchor #2383
Merged
fix validator anchor #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2019 17:35
sabau
reviewed
Mar 29, 2019
added 3 commits
March 29, 2019 18:15
Codecov Report
@@ Coverage Diff @@
## develop #2383 +/- ##
==========================================
+ Coverage 96.4% 96.4% +<.01%
==========================================
Files 106 106
Lines 2389 2391 +2
Branches 129 129
==========================================
+ Hits 2303 2305 +2
Misses 66 66
Partials 20 20
|
sabau
reviewed
Mar 29, 2019
| @@ -288,6 +298,11 @@ export default { | |||
| // status: active | |||
| return `green` | |||
| }, | |||
| // empty descriptions have a strange '[do-not-modify]' value which we don't want to show | |||
| website() { | |||
| const url = this.validator.description.website | |||
There was a problem hiding this comment.
minor: we could pass the parameter straight to the function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2323
Description:
Thank you! 🚀
For contributor:
PENDING.mdwith issue # and GitHub usernameFiles changedin the github PR explorerFor reviewer: