Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabo/changelog tool #2385

Merged
merged 12 commits into from
Apr 1, 2019
Merged

Fabo/changelog tool #2385

merged 12 commits into from
Apr 1, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Mar 29, 2019

Same but with fixed changed folder path

@codecov
Copy link

codecov bot commented Mar 29, 2019 •
edited
Loading

Codecov Report

Merging #2385 into develop will increase coverage by 0.05%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2385      +/-   ##
===========================================
+ Coverage     96.4%   96.45%   +0.05%     
===========================================
  Files          106      106              
  Lines         2389     2395       +6     
  Branches       129      129              
===========================================
+ Hits          2303     2310       +7     
+ Misses          66       65       -1     
  Partials        20       20
Impacted Files Coverage Δ
tasks/createReleasePR.js 100% <100%> (ø) ⬆️
app/src/renderer/vuex/modules/delegates.js 98.03% <0%> (-0.24%) ⬇️
app/src/renderer/components/common/TmPage.vue 100% <0%> (ø) ⬆️
app/src/renderer/vuex/store.js 100% <0%> (ø) ⬆️
app/src/renderer/components/wallet/LiCoin.vue 100% <0%> (ø) ⬆️
app/src/renderer/vuex/modules/keybase.js 100% <0%> (ø) ⬆️
app/src/renderer/scripts/keystore.js 100% <0%> (+2.32%) ⬆️

fedekunze
fedekunze reviewed Mar 29, 2019
View reviewed changes
tasks/changelog.js Outdated Show resolved Hide resolved
fedekunze
fedekunze suggested changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[undefined] [#undefined](https://github.com/cosmos/lunie/undefined/undefined) undefined @undefined

fedekunze
fedekunze approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK

@faboweb faboweb merged commit a33eef3 into develop Apr 1, 2019
@faboweb faboweb deleted the fabo/changelog-tool branch April 1, 2019 11:31
@faboweb faboweb mentioned this pull request Apr 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@jbibla jbibla Awaiting requested review from jbibla jbibla is a code owner

@sabau sabau Awaiting requested review from sabau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faboweb @sabau @fedekunze