automatic release created for v1.0.0-beta.43

CHANGELOG.md

@@ -7,6 +7,20 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [1.0.0-beta.43] - 2019-04-16
+
+### Added
+
+- [#2449](https://github.com/cosmos/lunie/pull/2449) added new circle ci badge to readme @jbibla
+
+### Fixed
+
+- [#2431](https://github.com/cosmos/lunie/issues/2431) check for ledger on submit to avoid action modal failures @jbibla
+- [#2449](https://github.com/cosmos/lunie/issues/2449) explore mode should not ask for password in action modals @jbibla
+- [#0](https://github.com/cosmos/lunie/issues/0) tm connected network still included the word testnet in the language @jbibla
+- [#2445](https://github.com/cosmos/lunie/issues/2445) page validator label should be ATOM not uatom @jbibla
+- [#2448](https://github.com/cosmos/lunie/issues/2448) proposal description is awkward @jbibla
+
 ## [1.0.0-beta.42] - 2019-04-08
 
 ### Fixed

LICENSE

@@ -1,6 +1,3 @@
-Tendermint Basecoin UI
-License: Apache2.0
-
  Apache License
  Version 2.0, January 2004
  http://www.apache.org/licenses/
@@ -189,7 +186,7 @@ License: Apache2.0
  same "printed page" as the copyright notice for easier
  identification within third-party archives.
 
- Copyright 2017 All in Bits, Inc
+ Copyright 2019 Lunie International Software Systems Inc.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

app/src/renderer/components/common/ActionModal.vue

@@ -231,7 +231,7 @@ export default {
  uatoms
  }),
  computed: {
- ...mapGetters([`connected`, `session`, `bondDenom`, `wallet`]),
+ ...mapGetters([`connected`, `session`, `bondDenom`, `wallet`, `ledger`]),
  requiresSignIn() {
  return !this.session.signedIn
  },
@@ -344,8 +344,13 @@ export default {
  }
  },
  async submit() {
+ this.submissionError = null
  track(`event`, `submit`, this.title, this.selectedSignMethod)
 
+ if (!this.ledger.isConnected || !this.ledger.cosmosApp) {
+ await this.connectLedger()
+ }
+
  try {
  await this.submitFn(
  this.gasEstimate,
@@ -362,7 +367,14 @@ export default {
  this.submissionError = null
  }, 5000)
  }
- }
+ },
+ async connectLedger() {
+ try {
+ await this.$store.dispatch(`connectLedgerApp`)
+ } catch (error) {
+ this.submissionError = `${this.submissionErrorPrefix}: ${error}.`
+ }
+ },
  },
  validations() {
  return {

app/src/renderer/vuex/modules/ledger.js

@@ -64,7 +64,7 @@ export default () => {
  case `U2F: Timeout`:
  throw new Error(`No Ledger found`)
  case `Cosmos app does not seem to be open`:
- throw new Error(`Cosmos app is not open`)
+ throw new Error(`Cosmos app is not open on the Ledger`)
  case `Unknown error code`: // TODO: create error for screensaver mode
  throw new Error(`Ledger's screensaver mode is on`)
  case `No errors`:

package.json

@@ -1,14 +1,14 @@
 {
  "name": "lunie",
  "productName": "lunie",
- "version": "1.0.0-beta.42",
- "description": "Lunie is a web based user interface for the Cosmos Hub.",
- "author": "All In Bits, Inc <hello@tendermint.com>",
+ "version": "1.0.0-beta.43",
+ "description": "Lunie is the user interface for the Cosmos Hub.",
+ "author": "Lunie International Software Systems Inc. <hello@lunie.io>",
  "license": "Apache-2.0",
  "homepage": "https://lunie.io",
  "repository": {
  "type": "git",
- "url": "git+https://github.com/cosmos/voyager.git"
+ "url": "git+https://github.com/luniehq/lunie.git"
  },
  "engines": {
  "node": ">=10.13.0"

test/unit/specs/components/common/ActionModal.spec.js

@@ -26,6 +26,10 @@ describe(`ActionModal`, () => {
  balances: [
  { denom: `uatom`, amount: `20000000` }
  ]
+ },
+ ledger: {
+ cosmosApp: {},
+ isConnected: true
  }
  }
  }
@@ -45,6 +49,89 @@ describe(`ActionModal`, () => {
  wrapper.vm.open()
  })
 
+ it(`should set the submissionError if the submission is rejected`, async () => {
+ const submitFn = jest
+ .fn()
+ .mockRejectedValue(new Error(`some kind of error message`))
+ const $store = { dispatch: jest.fn() }
+ const self = {
+ $store,
+ ledger: {
+ cosmosApp: {},
+ isConnected: true
+ },
+ submitFn,
+ submissionErrorPrefix: `PREFIX`
+ }
+ await ActionModal.methods.submit.call(self)
+
+ expect(self.submissionError).toEqual(`PREFIX: some kind of error message.`)
+ })
+
+ it(`should clear the submissionError after a timeout if the function is rejected`, async () => {
+ jest.useFakeTimers()
+
+ const submitFn = jest
+ .fn()
+ .mockRejectedValue(new Error(`some kind of error message`))
+ const $store = { dispatch: jest.fn() }
+ const self = {
+ $store,
+ ledger: {
+ cosmosApp: {},
+ isConnected: true
+ },
+ submitFn,
+ submissionErrorPrefix: `PREFIX`
+ }
+ await ActionModal.methods.submit.call(self)
+
+ jest.runAllTimers()
+ expect(self.submissionError).toEqual(null)
+ })
+
+ it(`should default to submissionError being null`, () => {
+ expect(wrapper.vm.submissionError).toBe(null)
+ })
+
+ it(`opens`, () => {
+ wrapper.vm.track = jest.fn()
+ wrapper.vm.open()
+
+ expect(wrapper.isEmpty()).not.toBe(true)
+ expect(wrapper.vm.track).toHaveBeenCalled()
+ })
+
+ it(`opens session modal and closes itself`, () => {
+ const $store = { commit: jest.fn() }
+ const self = { $store, close: jest.fn() }
+ ActionModal.methods.goToSession.call(self)
+ expect(self.close).toHaveBeenCalled()
+ expect($store.commit).toHaveBeenCalledWith(`setSessionModalView`, `welcome`)
+ expect($store.commit).toHaveBeenCalledWith(`toggleSessionModal`, true)
+ })
+
+ it(`shows a password input for local signing`, async () => {
+ wrapper.vm.step = `sign`
+ expect(wrapper.vm.selectedSignMethod).toBe(`local`)
+ await wrapper.vm.$nextTick()
+ expect(wrapper.find(`#password`).exists()).toBe(true)
+ })
+
+ it(`hides password input if signing with Ledger`, async () => {
+ wrapper.vm.session.sessionType = `ledger`
+ wrapper.vm.step = `sign`
+ expect(wrapper.vm.selectedSignMethod).toBe(`ledger`)
+ expect(wrapper.find(`#password`).exists()).toBe(false)
+ })
+
+ it(`should dispatch connectLedgerApp`, () => {
+ const $store = { dispatch: jest.fn() }
+ const self = { $store }
+ ActionModal.methods.connectLedger.call(self)
+ expect($store.dispatch).toHaveBeenCalledWith(`connectLedgerApp`)
+ })
+
  describe(`should show the action modal`, () => {
  describe(`when user has logged in`, () => {
  describe(`with local keystore`, () => {
@@ -96,26 +183,6 @@ describe(`ActionModal`, () => {
  expect(wrapper.vm.$el).toMatchSnapshot()
  })
  })
- it(`should default to submissionError being null`, () => {
- expect(wrapper.vm.submissionError).toBe(null)
- })
-
- it(`opens`, () => {
- wrapper.vm.track = jest.fn()
- wrapper.vm.open()
-
- expect(wrapper.isEmpty()).not.toBe(true)
- expect(wrapper.vm.track).toHaveBeenCalled()
- })
-
- it(`opens session modal and closes itself`, () => {
- const $store = { commit: jest.fn() }
- const self = { $store, close: jest.fn() }
- ActionModal.methods.goToSession.call(self)
- expect(self.close).toHaveBeenCalled()
- expect($store.commit).toHaveBeenCalledWith(`setSessionModalView`, `welcome`)
- expect($store.commit).toHaveBeenCalledWith(`toggleSessionModal`, true)
- })
 
  describe(`close modal`, () => {
  it(`closes`, () => {
@@ -195,7 +262,6 @@ describe(`ActionModal`, () => {
  })
 
  describe(`validates password and gas price`, () => {
-
  describe(`success`, () => {
  it(`when password is required`, () => {
  wrapper.vm.step = `sign`
@@ -271,29 +337,6 @@ describe(`ActionModal`, () => {
  })
  })
 
- it(`should set the submissionError if the submission is rejected`, async () => {
- const submitFn = jest
- .fn()
- .mockRejectedValue(new Error(`some kind of error message`))
- const self = { submitFn, submissionErrorPrefix: `PREFIX` }
- await ActionModal.methods.submit.call(self)
-
- expect(self.submissionError).toEqual(`PREFIX: some kind of error message.`)
- })
-
- it(`should clear the submissionError after a timeout if the function is rejected`, async () => {
- jest.useFakeTimers()
-
- const submitFn = jest
- .fn()
- .mockRejectedValue(new Error(`some kind of error message`))
- const self = { submitFn, submissionErrorPrefix: `PREFIX` }
- await ActionModal.methods.submit.call(self)
-
- jest.runAllTimers()
- expect(self.submissionError).toEqual(null)
- })
-
  describe(`runs validation and changes step`, () => {
  let self, getterValues
 
@@ -428,20 +471,6 @@ describe(`ActionModal`, () => {
  })
  })
 
- it(`shows a password input for local signing`, async () => {
- wrapper.vm.step = `sign`
- expect(wrapper.vm.selectedSignMethod).toBe(`local`)
- await wrapper.vm.$nextTick()
- expect(wrapper.find(`#password`).exists()).toBe(true)
- })
-
- it(`hides password input if signing with Ledger`, async () => {
- wrapper.vm.session.sessionType = `ledger`
- wrapper.vm.step = `sign`
- expect(wrapper.vm.selectedSignMethod).toBe(`ledger`)
- expect(wrapper.find(`#password`).exists()).toBe(false)
- })
-
  describe(`selected sign method`, () => {
  it(`selects local signed in with account`, () => {
  expect(wrapper.vm.selectedSignMethod).toBe(`local`)