Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabo/fix signin with local account #2525

Merged
merged 4 commits into from
May 2, 2019
Merged

Fabo/fix signin with local account #2525

merged 4 commits into from
May 2, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented May 2, 2019 •
edited
Loading

Apparently due to some merge conflicts the local signing in broke.

Description:

Thank you! 🚀

For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@faboweb faboweb merged commit f1d5147 into develop May 2, 2019
@faboweb faboweb deleted the fabo/fix-signin branch May 2, 2019 15:16
@faboweb faboweb mentioned this pull request May 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze Awaiting requested review from fedekunze

@jbibla jbibla Awaiting requested review from jbibla jbibla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@faboweb