Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miguel/1735 add missing step lines #2601

Merged
merged 9 commits into from
May 17, 2019
Merged

Miguel/1735 add missing step lines #2601

merged 9 commits into from
May 17, 2019

Conversation

migueog
Copy link
Contributor

@migueog migueog commented May 16, 2019 •
edited
Loading

Closes #1735

Description:

Added missing step lines and fixed the alignment of the numbers within the circles

Desktop
Screen Shot 2019-05-16 at 3 32 12 PM

iPhone 6/7
Screen Shot 2019-05-16 at 3 33 02 PM

Tablet (?)
Screen Shot 2019-05-16 at 3 32 29 PM

Thank you! 🚀

For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@migueog migueog requested a review from jbibla May 16, 2019 19:14
@migueog migueog requested a review from faboweb as a code owner May 16, 2019 19:14
@jbibla
Copy link
Collaborator

jbibla commented May 16, 2019

nice! is there actually that much padding above and below the steps? is that on mobile or tablet or something?

@migueog
Copy link
Contributor Author

migueog commented May 16, 2019

@jbibla That's a mobile view but I've updated the PR with some better screenshots!

@faboweb faboweb merged commit a5b8768 into develop May 17, 2019
@faboweb faboweb deleted the miguel/1735-Add-missing-step-lines branch May 17, 2019 07:28
@faboweb
Copy link
Collaborator

faboweb commented May 17, 2019

Went ahead on this as the current release version was shaky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faboweb faboweb faboweb approved these changes

@jbibla jbibla Awaiting requested review from jbibla jbibla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement multi step action modals
3 participants
@migueog @jbibla @faboweb