Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benji/ext issue 29 calculate subtotal in SessionApprove TableInvoice #2787

Merged
merged 16 commits into from
Jul 4, 2019
Merged

Benji/ext issue 29 calculate subtotal in SessionApprove TableInvoice #2787

merged 16 commits into from
Jul 4, 2019

Conversation

thebkr7
Copy link
Contributor

@thebkr7 thebkr7 commented Jun 28, 2019

Closes #29 Extension

Description:

Refactors SessionApprove to pass TableInvoice the subtotal fee and amount of the transaction. TableInvoice was refactored in PR #2785

Thank you! 🚀

For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@thebkr7
Copy link
Contributor Author

thebkr7 commented Jul 3, 2019

@colw Any chance you could look into the failing tests. I imagine it is something simple that I am missing.

@thebkr7 thebkr7 changed the base branch from chrome-extension to develop July 3, 2019 18:08
@faboweb
Copy link
Collaborator

faboweb commented Jul 4, 2019

fixed the JSON.parse issue. but there are more

colw
colw reviewed Jul 4, 2019
View reviewed changes
Copy link
Contributor

@colw colw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helped out with your tests.

Also, there is a typo: s/deligates/delegates

test/unit/specs/components/common/SessionApprove.spec.js Outdated Show resolved Hide resolved
src/scripts/parsers.js Show resolved Hide resolved
src/components/common/SessionApprove.vue Outdated Show resolved Hide resolved
src/components/common/SessionApprove.vue
<!-- <TableInvoice :fees="fees" /> -->

<TableInvoice
:amount="amount"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't (yet) pass the tests since the TableInvoice code is in the other PR #2802

@thebkr7 thebkr7 marked this pull request as ready for review July 4, 2019 18:18
@thebkr7 thebkr7 requested a review from jbibla as a code owner July 4, 2019 18:18
@jbibla jbibla merged commit 4a89aa6 into develop Jul 4, 2019
@jbibla jbibla deleted the Benji/Ext-issue-29-Calculate-Subtotal-in-Approve-TableInvoice branch July 4, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colw colw colw left review comments

@faboweb faboweb faboweb left review comments

@jbibla jbibla jbibla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Network Monitoring
4 participants
@thebkr7 @faboweb @colw @jbibla