Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests #28

Merged
merged 74 commits into from
Nov 8, 2017
Merged

Adding tests #28

merged 74 commits into from
Nov 8, 2017

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Nov 1, 2017

Some more tests for the main process missing.

@mappum
Copy link
Contributor

mappum commented Nov 2, 2017

Hey @faboweb, thanks for the awesome work on the tests! The startup process look really thorough and really needed this, and you're basically carrying the team right now 💯

I can't get it to run on my machine yet though, I get an error from jest, any idea how to fix:

> cross-env LOGGING=false jest

YError: Invalid first argument. Expected string or function but received boolean.
    at argumentTypeError (/Users/mappum/Projects/cosmos-ui/node_modules/yargs/lib/argsert.js:70:9)
    at /Users/mappum/Projects/cosmos-ui/node_modules/yargs/lib/argsert.js:52:39
    at Array.forEach (<anonymous>)
    at module.exports (/Users/mappum/Projects/cosmos-ui/node_modules/yargs/lib/argsert.js:45:21)
    at Object.Yargs.self.version (/Users/mappum/Projects/cosmos-ui/node_modules/yargs/yargs.js:718:5)
    at _buildArgv (/Users/mappum/Projects/cosmos-ui/node_modules/jest/node_modules/jest-cli/build/cli/index.js:118:3)
    at Object.<anonymous> (/Users/mappum/Projects/cosmos-ui/node_modules/jest/node_modules/jest-cli/build/cli/index.js:37:18)
    at Generator.next (<anonymous>)
    at step (/Users/mappum/Projects/cosmos-ui/node_modules/jest/node_modules/jest-cli/build/cli/index.js:45:2466)
    at /Users/mappum/Projects/cosmos-ui/node_modules/jest/node_modules/jest-cli/build/cli/index.js:45:2696

```i

@faboweb
Copy link
Collaborator Author

faboweb commented Nov 2, 2017

No worries, I have fun :)
Can you try running just jest (without cross-env) and jest .* (providing a file glob as first argument)?

Copy link
Contributor

@mappum mappum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mappum mappum merged commit aba8b47 into develop Nov 8, 2017
@mappum mappum deleted the adding-tests branch November 8, 2017 20:18
faboweb added a commit that referenced this pull request Jun 2, 2020
Fabo/change schema names in db access queries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants