Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jordan/session clean up #2818

Merged
merged 7 commits into from
Jul 12, 2019
Merged

Jordan/session clean up #2818

merged 7 commits into from
Jul 12, 2019

Conversation

jbibla
Copy link
Collaborator

@jbibla jbibla commented Jul 10, 2019

Description:

  • removed unused session screens
  • moved all session css to session.css (or deleted it)

Thank you! 🚀

For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@jbibla jbibla requested review from colw and faboweb as code owners July 10, 2019 18:32
@faboweb
Copy link
Collaborator

faboweb commented Jul 11, 2019

SessionApprove wasn't yet moved to the extension or am I mistaken?

thebkr7
thebkr7 previously approved these changes Jul 11, 2019
View reviewed changes
@jbibla
Merge branch 'develop' into jordan/session-clean-up
873ae2d 
# Conflicts:
#	src/components/common/SessionApprove.vue
@colw
Copy link
Contributor

colw commented Jul 11, 2019

SessionApprove wasn't yet moved to the extension or am I mistaken?

Moved now and deleted here in #2825

I moved the test over to the extension test PR too

@colw colw merged commit b84d29b into develop Jul 12, 2019
@colw colw deleted the jordan/session-clean-up branch July 12, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colw colw colw approved these changes

@thebkr7 thebkr7 thebkr7 left review comments

@faboweb faboweb Awaiting requested review from faboweb faboweb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbibla @faboweb @colw @thebkr7