Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/2929 test extension in lunie #2946

Merged
merged 26 commits into from
Sep 9, 2019
Merged

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Sep 4, 2019

Closes #2929

Description:

Needs https://github.com/luniehq/lunie-browser-extension/pull/95 to be done before

Thank you! 🚀


For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@faboweb faboweb marked this pull request as ready for review September 6, 2019 09:29
@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #2946 into develop will increase coverage by 0.22%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2946      +/-   ##
===========================================
+ Coverage    92.83%   93.06%   +0.22%     
===========================================
  Files          129      129              
  Lines         2234     2248      +14     
  Branches       377      388      +11     
===========================================
+ Hits          2074     2092      +18     
+ Misses         155      151       -4     
  Partials         5        5
Impacted Files Coverage Δ
src/components/staking/TableValidators.vue 96.15% <0%> (ø) ⬆️
src/components/staking/LiValidator.vue 66.66% <0%> (ø) ⬆️
src/ActionModal/components/ActionModal.vue 33.09% <0%> (ø) ⬆️
src/components/staking/PanelSort.vue 100% <0%> (ø) ⬆️
src/components/staking/PageValidator.vue 100% <0%> (ø) ⬆️
src/vuex/modules/transactions.js 100% <0%> (ø) ⬆️
src/components/governance/PageProposals.vue
src/components/governance/TabProposals.vue 100% <0%> (ø)
src/vuex/getters.js 82.25% <0%> (+1.55%) ⬆️
src/vuex/modules/blocks.js 100% <0%> (+1.69%) ⬆️
... and 1 more

@faboweb faboweb merged commit 07b6cf4 into develop Sep 9, 2019
@faboweb faboweb deleted the fabo/2929-test-extension-in-lunie branch September 9, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run extension e2e tests when merging lunie
2 participants