-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mario/2965 set max button pending changes #2974
Conversation
When entering the values manually on the delegation modal it doesn't show the message. |
Fixed! |
Codecov Report
@@ Coverage Diff @@
## develop #2974 +/- ##
========================================
Coverage 92.86% 92.86%
========================================
Files 133 133
Lines 2270 2270
Branches 376 377 +1
========================================
Hits 2108 2108
Misses 157 157
Partials 5 5
|
Codecov Report
@@ Coverage Diff @@
## develop #2974 +/- ##
===========================================
+ Coverage 96.82% 96.83% +<.01%
===========================================
Files 134 134
Lines 2271 2273 +2
Branches 385 386 +1
===========================================
+ Hits 2199 2201 +2
Misses 67 67
Partials 5 5
|
some nice improvements here mario! as opposed to leaving extra space for the max message and to solve the jumping around problem, let's add the max message under the input like a validation message? perhaps with the warning colour instead of the red colour. i think this is the best solution for this. |
Sweet! Thank you. |
Closes #2965
Description:
Thank you! 🚀
For contributor:
yarn changelog
for a guided process.Files changed
in the github PR explorerFor reviewer: