Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mario/2965 set max button pending changes #2974

Merged
merged 38 commits into from
Sep 16, 2019
Merged

Conversation

mariopino
Copy link
Contributor

Closes #2965

Description:

  • Change Set Max button style to secondary.
  • Fixed bug in warning message in send and delegate modals: Warning message is shown if we enter the max amount manually.
  • Unify denomination input suffix in send, delegate and undelegate modals.
  • Cleanup duplicate code in TmBtn component.

Thank you! 🚀


For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@faboweb
Copy link
Collaborator

faboweb commented Sep 10, 2019

When entering the values manually on the delegation modal it doesn't show the message.
The note about no more tokens to pay for fees pushes everything else around. Is there a way to fi that?

@mariopino
Copy link
Contributor Author

When entering the values manually on the delegation modal it doesn't show the message.
The note about no more tokens to pay for fees pushes everything else around. Is there a way to fi that?

Fixed!

@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

Merging #2974 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop    #2974   +/-   ##
========================================
  Coverage    92.86%   92.86%           
========================================
  Files          133      133           
  Lines         2270     2270           
  Branches       376      377    +1     
========================================
  Hits          2108     2108           
  Misses         157      157           
  Partials         5        5
Impacted Files Coverage Δ
src/ActionModal/components/UndelegationModal.vue 100% <ø> (ø) ⬆️
src/ActionModal/components/SendModal.vue 100% <100%> (ø) ⬆️
src/ActionModal/components/DelegationModal.vue 100% <100%> (ø) ⬆️

@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

Merging #2974 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2974      +/-   ##
===========================================
+ Coverage    96.82%   96.83%   +<.01%     
===========================================
  Files          134      134              
  Lines         2271     2273       +2     
  Branches       385      386       +1     
===========================================
+ Hits          2199     2201       +2     
  Misses          67       67              
  Partials         5        5
Impacted Files Coverage Δ
src/ActionModal/components/UndelegationModal.vue 100% <ø> (ø) ⬆️
src/ActionModal/components/ActionModal.vue 98.75% <ø> (ø) ⬆️
src/ActionModal/components/SendModal.vue 100% <100%> (ø) ⬆️
src/ActionModal/components/DelegationModal.vue 100% <100%> (ø) ⬆️

@jbibla
Copy link
Collaborator

jbibla commented Sep 12, 2019

some nice improvements here mario!

as opposed to leaving extra space for the max message and to solve the jumping around problem, let's add the max message under the input like a validation message? perhaps with the warning colour instead of the red colour.

i think this is the best solution for this.

@faboweb
Copy link
Collaborator

faboweb commented Sep 16, 2019

Probably needs some margin:
image

@mariopino
Copy link
Contributor Author

Probably needs some margin:
image

Yep, It's not finished yet, also color must be warning/yellow.

@mariopino
Copy link
Contributor Author

image

@faboweb faboweb merged commit 2eed84c into develop Sep 16, 2019
@faboweb
Copy link
Collaborator

faboweb commented Sep 16, 2019

Sweet! Thank you.

@faboweb faboweb deleted the mario/2965-set-max-button branch September 16, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set Max button pending changes
3 participants