Fix HTML links on godoc #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shashaneRanasinghe <shashane.ranasinghe@gmail.com>
echarrod
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Thanks for the contribution @shashaneRanasinghe! Just sharing a preview of the updated godoc now for reference:
Probably wise to not put the code tags on separate lines, we'll address that in a separate MR with a format differentiator of some sort.
Cheers!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the HTML links for SendRequest, additionally fixed the unordered list, and made the Note look emphasized.
I was not able to fix the HTML link in the PostMarketOrder since the full URL was not provided. We can show code blocks instead of using the 'code' tags but the code will be displayed in a new line. which would look as follows.
Addresses: #97