workflow: Align API and Workflow implementation #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewwormald
requested review from
pierredup,
neilgarb,
andreis,
echarrod,
arcturial,
wesrobin,
pkachelhoffer,
adamhicks,
carlosfrancia,
wenkanglu,
jrkilloran and
solethus
|
richardj1308
approved these changes
Jul 16, 2024
echarrod
reviewed
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforcing the alignment of these two. I think I previously didn't do it as they were generic but its simple enough to add to a test file. Will break tests passing if they dont align as opposed to creating a satus type in the workflow package just for this enforcement. Currently nothing uses workflow.API but I believe there is value here to use it in testing when you dont want the actual workflow running.