Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: Clean up options patterns and allow workflow defaults #6

Merged
merged 8 commits into from
Jul 30, 2024

Conversation

andrewwormald
Copy link
Collaborator

@andrewwormald andrewwormald commented Jul 29, 2024

This MR:

  • Cleans up the repetitive pattern of setting options for processes.
  • Adds the ability to set the defaults config for all the processes in the workflow.
  • Adds a benchmark test.
  • Removes the timeout store as a core dependency and allows for it to be optional based on whether the user needs to use timeouts or not. This also results in not running 2 goroutines used to manage the process if its not being used.

@andrewwormald andrewwormald marked this pull request as ready for review July 29, 2024 15:36
connector.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jul 30, 2024

Copy link

@neilgarb neilgarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewwormald andrewwormald merged commit 504414c into main Jul 30, 2024
1 check passed
@andrewwormald andrewwormald deleted the andreww-cleanupOptionsPattern branch August 14, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants