Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

Commit

Permalink
ci: Stop using kitek/dartanalyzer-annotations-action
Browse files Browse the repository at this point in the history
The dartanalyzer has a bug when excluding files that have been around
for a long time now, and since it is now deprecated in flavour of `dart
analyze` it is very unlikely to be fixed any time soon.

Since this action uses dartanalyzer and we need to exclude mocks, we
can't use it anymore.

dart-lang/sdk#25551
  • Loading branch information
llucax committed Sep 21, 2021
1 parent 8801ccc commit 0db3c16
Showing 1 changed file with 3 additions and 18 deletions.
21 changes: 3 additions & 18 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,24 +38,9 @@ jobs:
- name: Generate unit tests mocks
run: tool/ci mocks-gen

# Analyze step needs different config for pull_request and push, so it is
# duplicated with if conditions to use the correct configuration for each
- name: Analyze (push)
if: github.event_name == 'push' && matrix.test_type == 'static'
uses: kitek/dartanalyzer-annotations-action@v1
env:
GITHUB_TOKEN: ${{ github.token }}
with:
check_name: test
commit_sha: ${{ github.sha }}
- name: Analyze (pull_request)
if: github.event_name == 'pull_request' && matrix.test_type == 'static'
uses: kitek/dartanalyzer-annotations-action@v1
env:
GITHUB_TOKEN: ${{ github.token }}
with:
check_name: test
commit_sha: ${{ github.event.pull_request.head.sha }}
- name: Analyze
if: matrix.test_type == 'static'
run: tool/ci analyze

- name: Check format
run: flutter format -n --set-exit-if-changed lib test example
Expand Down

0 comments on commit 0db3c16

Please sign in to comment.