bugfix for gneerics class #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota42y
force-pushed
the
feat/support_generics_class
branch
from
75d3f5c to
a41f82e
Compare
ota42y
commented
Sep 11, 2023
|
|
||
|
|
||
| class ListGenericResponse(GenericModel, Generic[T]): | ||
| items: List[GenericResponse[T]] |
There was a problem hiding this comment.
I used list here last time, but in python 3.7 etc. it has to be List, so I modified it
|
@ota42y Hi, there seems to be somewhere else that needs to normalize the name, such as the Also, I would like to add And can you write a unit test in new Can you continue to complete it? |
When we use generics in responses, the schema name include `[]` but [OpenAPI 3 doesn't allow it](https://spec.openapis.org/oas/v3.1.0#components-object). ``` All the fixed fields declared above are objects that MUST use keys that match the regular expression: ^[a-zA-Z0-9\.\-_]+$. ``` The pydantic normalize all `$ref` but the schema name ( `components.schemas` ) set by this library so we shuld normalize name using pydantic's function.
ota42y
force-pushed
the
feat/support_generics_class
branch
from
a41f82e to
a99a495
Compare
Closed
|
@luolingchun
This PR changes will be conflict to this PR #106 but I think thease test should be in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
pytest testsand no failed.flake8 flask_openapi3 tests examplesand no failed.mypy flask_openapi3and no failed.mkdocs serveand no failed.When we use generics in responses, the schema name include
[]but OpenAPI 3 doesn't allow it.The pydantic normalize all
$refbut the schema name (components.schemas) set by this library so we shuld normalize name using pydantic's function.