Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label designer coordinate fields #337

Merged
merged 4 commits into from
Sep 30, 2022

Conversation

aorin
Copy link
Contributor

@aorin aorin commented Sep 28, 2022

https://www.pivotaltracker.com/story/show/176819698

Adds coordinate fields (coordinate verbatim and point coordinates) to Vihko label designer.

@aorin aorin requested a review from olzraiti September 28, 2022 07:00
@aorin
Copy link
Contributor Author

aorin commented Sep 28, 2022

@olzraiti The function getTransformGeometryDataFunction (in the file projects/laji/src/app/shared/service/pdf-label.service.ts) parses coordinateVerbatim and point coordinates from gathering/unit geometry. I'm not sure if it works for all geometries in our documents, can you check how it looks?

@olzraiti olzraiti self-assigned this Sep 28, 2022
@esko-piirainen esko-piirainen added this to the Release 60 milestone Sep 28, 2022
@olzraiti
Copy link
Member

The getTransformGeometryDataFunction part seems to be ok. Should it take into account other possible sources of geometry though, like MY.gatheringEvent (child of MY.document)?

@olzraiti
Copy link
Member

About gatheringEvent.geometry - I guess the label designer is used only for the trip report form which doesn't use that field, so in practice that field wouldn't need to be there. But I think it would be good to keep the label designer as form agnostic as possible, so maybe it'd be good to have it also?

@aorin
Copy link
Contributor Author

aorin commented Sep 30, 2022

I don't think gatheringEvent.geometry is needed. The pdf label service which has those geometry transforms uses the trip form to get all available fields. It would also need other changes (e.g. more fields to skipFields variable) if we would decide to change that.

@olzraiti
Copy link
Member

Ok, sounds reasonable if it wouldn't anyway work for other forms. Approved 👍

@olzraiti olzraiti merged commit d40ea0c into development Sep 30, 2022
@olzraiti olzraiti deleted the label-designer-coordinate-fields-176819698 branch September 30, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants