feat/esp ws #406
Merged
feat/esp ws #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salem-Tho
force-pushed
the
feat/esp_ws
branch
6 times, most recently
from
27bb46e to
417de5b
Compare
nicolas-rabault
requested changes
Dec 9, 2022
There was a problem hiding this comment.
The code sounds good to me, the only thing remaining is your commit comment wording.
Please use [DETAIL] keyword to define that your are working on ESP_WS or something.
Make sure Commit start with a Maj and that the comment can be understood by any developers that don't know the context of the commit.
Salem-Tho
force-pushed
the
feat/esp_ws
branch
from
417de5b to
b7d5e6e
Compare
|
done |
Salem-Tho
force-pushed
the
feat/esp_ws
branch
2 times, most recently
from
e58643c to
423b6eb
Compare
JeromeGalan
force-pushed
the
feat/esp_ws
branch
from
423b6eb to
de84fb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description section
Description and dependencies
Please include here a summary of the changes and the related issue. List any dependencies that are required for this change.
Changes
Please choose the relevant options:
Related issue(s)
Provide a list of the related issues that will be fixed by this PR.
WARNING: Do not edit the checklist below.
Developer section
QA section
🆕 Feature: [Feature] Description...
🆕 Added: [Feature] Description...
🆕 Changed: [Feature] Description...
🛠️ Fix: [Feature] Description...