Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/esp ws #406

Merged
merged 9 commits into from
Dec 13, 2022
Merged

feat/esp ws #406

merged 9 commits into from
Dec 13, 2022

Conversation

Salem-Tho
Copy link
Member

@Salem-Tho Salem-Tho commented Dec 1, 2022

PR Description section

  • add serial exemple esp-idf
  • add ws exemple esp-idf
  • add ws exemple arduino
  • Fix HAL esp32

Description and dependencies

Please include here a summary of the changes and the related issue. List any dependencies that are required for this change.

Changes

Please choose the relevant options:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.


WARNING: Do not edit the checklist below.


Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@Salem-Tho Salem-Tho added the advanced Advanced skills are needed for this subject label Dec 1, 2022
@Salem-Tho Salem-Tho added this to the 2.8.0 milestone Dec 1, 2022
@Salem-Tho Salem-Tho self-assigned this Dec 1, 2022
@Salem-Tho Salem-Tho force-pushed the feat/esp_ws branch 6 times, most recently from 27bb46e to 417de5b Compare December 2, 2022 16:11
@Salem-Tho Salem-Tho changed the base branch from main to rc_2.8.0 December 9, 2022 13:58
Copy link
Member

@nicolas-rabault nicolas-rabault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code sounds good to me, the only thing remaining is your commit comment wording.
Please use [DETAIL] keyword to define that your are working on ESP_WS or something.
Make sure Commit start with a Maj and that the comment can be understood by any developers that don't know the context of the commit.

@Salem-Tho
Copy link
Member Author

done

@Salem-Tho Salem-Tho force-pushed the feat/esp_ws branch 2 times, most recently from e58643c to 423b6eb Compare December 9, 2022 15:42
Copy link
Member

@JeromeGalan JeromeGalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

Copy link
Member

@nicolas-rabault nicolas-rabault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice!

@JeromeGalan JeromeGalan merged commit eee89ea into rc_2.8.0 Dec 13, 2022
@JeromeGalan JeromeGalan deleted the feat/esp_ws branch December 13, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced Advanced skills are needed for this subject
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants