Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in v1.10.0+ #341

Open
ljharb opened this issue Dec 16, 2024 · 0 comments
Open

Breaking change in v1.10.0+ #341

ljharb opened this issue Dec 16, 2024 · 0 comments

Comments

@ljharb
Copy link

ljharb commented Dec 16, 2024

psl v1 doesn't have an engines field, which means it supports all versions of node.

v1.9 and below worked fine in node <= 4, but v1.10.0 contains untranspiled spread syntax and const/lets, and thus breaks in node 4 and below. Can you restore that support in a v1? It's fine to publish a v2 that drops it explicitly after that, of course :-)

(i'd also suggest expanding the CI matrix to include every supported node version, not just down to v8)

ljharb added a commit to ljharb/prop-types-exact that referenced this issue Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant