Adapt type simplifications #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
force-pushed
the
adapt_type_simplifications
branch
2 times, most recently
from
5cf723b to
666da71
Compare
- Significant refactoring has been done across multiple files to include the `SecEng` trait and `RecursiveSNARKTrait`, replacing `C1LEM`, `E2`, `C2` as well as `GrumpkinEngine` and `VestaEngine`. - Adjustments to various function arguments and returns to reflect the above changes, primarily noted in `public_parameters/mod.rs` and `proof/nova.rs`. - The implementation of `NonUniformCircuit` has been updated to only work with `E1` and has `C1` and `C2` types added. - removal of `MultiFrame` usage from `PublicParams` and simplification of type declarations. - Replaced functions across files, mainly `public_params`, `supernova_circuit_params`, `supernova_aux_params`, and `supernova_public_params`, have been adjusted for syntax changes.
- Consolidated the use of `nova` related code with the use of `seceng` being changed to `Dual` in various contexts across multiple files.
- Simplified type declarations and trait bounds in `src/public_parameters/mod.rs` for improved readability - Updated `TestConstraintSystem` initialization in `src/proof/nova.rs`
huitseeker
force-pushed
the
adapt_type_simplifications
branch
from
e6175db to
b5d413d
Compare
arthurpaulino
previously approved these changes
Feb 5, 2024
porcuquine
previously approved these changes
Feb 5, 2024
huitseeker
dismissed stale reviews from porcuquine, samuelburnham, and arthurpaulino
via
ecec5fc
huitseeker
force-pushed
the
adapt_type_simplifications
branch
from
2213700 to
ecec5fc
Compare
arthurpaulino
previously approved these changes
Feb 5, 2024
porcuquine
previously approved these changes
Feb 5, 2024
huitseeker
dismissed stale reviews from porcuquine and arthurpaulino
via
442f271
huitseeker
force-pushed
the
adapt_type_simplifications
branch
from
ecec5fc to
442f271
Compare
arthurpaulino
approved these changes
Feb 5, 2024
porcuquine
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the companion PR for lurk-lang/arecibo#297
Fixes #1089