Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coroutine refactor #1213

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Coroutine refactor #1213

merged 4 commits into from
Mar 13, 2024

Conversation

gabriel-barrett
Copy link
Contributor

This PR simplifies a few things and fixes a couple of clones.

  1. No need to implement Prover trait for memoset. It just doesn't fit very well the Prover architecture, as you see by all the "unimplementeds"
  2. Simplified CoroutineCircuit. It doesn't need the input field anymore as we do not need to use the Prover API, and separates witness stuff from data that is only needed for synthesis
  3. Removed clones from CoroutineCircuit, CircuitScope and LogMemoCircuit by introducing lifetime parameters. References that are only needed for witness gen are now optional

@gabriel-barrett gabriel-barrett requested review from a team as code owners March 12, 2024 12:50
@gabriel-barrett gabriel-barrett added this pull request to the merge queue Mar 13, 2024
Merged via the queue into lurk-lab:main with commit 4e5cd03 Mar 13, 2024
11 checks passed
@gabriel-barrett gabriel-barrett deleted the coroutine-circuit-refactor branch March 13, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@porcuquine porcuquine porcuquine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabriel-barrett @porcuquine