Refactor to use bellpepper's new conditional selects #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Function `conditionally_select_vec` is removed and replaced with `conditionally_select_slice` across multiple files for consistency. - Duplicate functions `conditionally_select` and `conditionally_select_vec` are removed from various modules. - Unused import, `itertools::Itertools`, removed from `src/gadgets/utils.rs`.
huitseeker
force-pushed
the
conditionally_select
branch
from
09038e0 to
a4fc35f
Compare
mpenciak
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conditionally_select_vecis removed and replaced withconditionally_select_sliceacross multiple files for consistency.conditionally_selectandconditionally_select_vecare removed from various modules.itertools::Itertools, removed fromsrc/gadgets/utils.rs.See lurk-lang/bellpepper#85