Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Antlr & Rice updated; refactored Token wrapper; added CodeQL workflow #140

Merged
merged 4 commits into from
Jan 21, 2024
Merged

Antlr & Rice updated; refactored Token wrapper; added CodeQL workflow #140

merged 4 commits into from
Jan 21, 2024

Conversation

maxirmx
Copy link
Contributor

@maxirmx maxirmx commented Dec 19, 2023

No description provided.

@maxirmx maxirmx force-pushed the maxirmx-segfault-again branch from 75532a3 to 16fb0bd Compare December 19, 2023 13:50
@maxirmx maxirmx changed the title Replaced Rice:Array with std:vector Refactored Antlr token stream Ruby wrapper Dec 23, 2023
@maxirmx maxirmx force-pushed the maxirmx-segfault-again branch 4 times, most recently from 391cb83 to 44b532d Compare December 27, 2023 10:56
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@maxirmx maxirmx force-pushed the maxirmx-segfault-again branch from 78a6c58 to 44c2294 Compare December 30, 2023 20:20
@maxirmx maxirmx force-pushed the maxirmx-segfault-again branch 4 times, most recently from 8039484 to 47475cf Compare January 18, 2024 21:49
@maxirmx maxirmx force-pushed the maxirmx-segfault-again branch from 99192e3 to 5b7e806 Compare January 20, 2024 14:26
@maxirmx maxirmx changed the title Refactored Antlr token stream Ruby wrapper Antlr & Rice updated; refactored Token wrapper Jan 20, 2024
@maxirmx maxirmx changed the title Antlr & Rice updated; refactored Token wrapper Antlr & Rice updated; refactored Token wrapper; added CodeQL Jan 20, 2024
@maxirmx maxirmx force-pushed the maxirmx-segfault-again branch from 5b7e806 to aaca3d0 Compare January 20, 2024 20:02
@maxirmx maxirmx changed the title Antlr & Rice updated; refactored Token wrapper; added CodeQL Antlr & Rice updated; refactored Token wrapper; added CodeQL workflow Jan 20, 2024
@maxirmx
Copy link
Contributor Author

maxirmx commented Jan 20, 2024 •
edited
Loading

This PR introduces updates of rice and antlr4-native gems including fixes suggested by Ribose

I do not think that expressir crashes are elimated. It is just coincidence that the new version is more stable since fixed rice issues did not affect expressir.
I believe expressir is affected by two reproducable rice/antlr4-ruby issues that are not fixed (yet)

@maxirmx maxirmx marked this pull request as ready for review January 20, 2024 22:34
@maxirmx maxirmx requested a review from ronaldtse January 20, 2024 22:36
@maxirmx maxirmx merged commit e1759d7 into main Jan 21, 2024
41 checks passed
@maxirmx maxirmx deleted the maxirmx-segfault-again branch January 21, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldtse ronaldtse ronaldtse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxirmx @ronaldtse