Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding enum methods to serializeable #208

Merged
merged 8 commits into from
Dec 24, 2024

Conversation

HassanAkbar
Copy link
Member

Add enum methods to serializable

fixes #201

@HassanAkbar HassanAkbar marked this pull request as draft December 12, 2024 18:53
Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a section in the README about using this use case, i.e. values: [...] with collection: true (is this correct?).

@HassanAkbar
Copy link
Member Author

Let's add a section in the README about using this use case, i.e. values: [...] with collection: true (is this correct?).

@ronaldtse Yes that is correct and some convenience methods are added for enum values, I'll update the readme after finalizing this PR.

@ronaldtse
Copy link
Contributor

@HassanAkbar is this completed? Could you please help merge since it is blocking another task at metanorma/suma#18 ? Thanks!

@HassanAkbar
Copy link
Member Author

@HassanAkbar is this completed? Could you please help merge since it is blocking another task at metanorma/suma#18 ? Thanks!

@ronaldtse Sure, I'll finalize and merge this in a bit.

@HassanAkbar HassanAkbar marked this pull request as ready for review December 23, 2024 10:10
@HassanAkbar HassanAkbar force-pushed the feature/adding_enum_methods_to_serializeable branch from 32b52e2 to a3d975e Compare December 23, 2024 10:36
@HassanAkbar HassanAkbar force-pushed the feature/adding_enum_methods_to_serializeable branch from a3d975e to 6632cbd Compare December 23, 2024 10:40
@HassanAkbar HassanAkbar merged commit 13f2621 into main Dec 24, 2024
29 of 81 checks passed
@HassanAkbar HassanAkbar deleted the feature/adding_enum_methods_to_serializeable branch December 24, 2024 07:24
@HassanAkbar
Copy link
Member Author

@ronaldtse Version 0.4.0 released for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add enum methods
3 participants