Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨feat: Add DeleteContent method for storage #117

Merged
merged 1 commit into from
Feb 24, 2024
Merged

✨feat: Add DeleteContent method for storage #117

merged 1 commit into from
Feb 24, 2024

Conversation

alperencelik
Copy link
Contributor

This PR aims to add 'DeleteContent' method for storage objects. Here is the relevant API documentation:

https://pve.proxmox.com/pve-docs/api-viewer/index.html#/nodes/{node}/storage/{storage}/content/{volume}

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (fdb95a1) 25.95% compared to head (f910ba6) 25.66%.
Report is 5 commits behind head on main.

Files Patch % Lines
storage.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   25.95%   25.66%   -0.30%     
==========================================
  Files          15       15              
  Lines        1753     1773      +20     
==========================================
  Hits          455      455              
- Misses       1278     1298      +20     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alperencelik
Copy link
Contributor Author

alperencelik commented Feb 22, 2024

I've attempted to enhance enabling the deletion of contents by name, as the current deleteVolume() method's private status and dependency on specific content types (iso, vztmpl, and backup) limit this functionality. I would like to hear opinions as well.

@luthermonson luthermonson merged commit bbc658b into luthermonson:main Feb 24, 2024
1 of 3 checks passed
@luthermonson
Copy link
Owner

@alperencelik looks good for now, if we need to do more we can always change it

@alperencelik
Copy link
Contributor Author

Thank you so much for review @luthermonson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants