Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed types in AgentExecStatus struct #123

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

mperezd
Copy link
Contributor

@mperezd mperezd commented Feb 27, 2024

Fixed types according to proxmox API in AgentExecStatus struct

@luthermonson
Copy link
Owner

i think this one needs merging first since you have that Exited check in the other PR, ill see if that works and if it breaks and needs a rebase im sorry

@luthermonson
Copy link
Owner

linter didnt like the spacing on Exited, should be a simple fix. i usually run a file watcher to run goimports on my files so this part is automated and i don't have to worry about it.

@mperezd
Copy link
Contributor Author

mperezd commented Mar 6, 2024

I think is fixed now, thanks.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 26.28%. Comparing base (fdb95a1) to head (54ab623).
Report is 9 commits behind head on main.

Files Patch % Lines
virtual_machine.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   25.95%   26.28%   +0.33%     
==========================================
  Files          15       15              
  Lines        1753     1803      +50     
==========================================
+ Hits          455      474      +19     
- Misses       1278     1309      +31     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luthermonson luthermonson merged commit ae11add into luthermonson:main Mar 7, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants