Basic backup logic #133
Basic backup logic #133
Conversation
vzdump api call
struct tag fix
replace vzdump method based on proxmox ve api
| func (n *Node) Vzdump(ctx context.Context, params *VirtualMachineBackupOptions) (task *Task, err error) { | ||
| var upid UPID | ||
|
|
||
| if params == nil { |
There was a problem hiding this comment.
API docs read like all params are optional https://pve.proxmox.com/pve-docs/api-viewer/index.html#/nodes/{node}/vzdump
you sure you dont want to allow nil params? I haven't tested this but it reads like empty post data should still create a backup with some form of defaults. maybe confirm and let's drop the check?
types.go
Outdated
| ModeType = string | ||
| CompressType = string |
There was a problem hiding this comment.
these are already types and "mode" and "compress" are pretty generic and these are specific for the vzdump params. maybe better if you do VirtualMachineBackupMode and VirtualMachineBackupCompress
| Mode ModeType `json:"mode,omitempty"` | ||
| Compress CompressType `json:"compress,omitempty"` | ||
| Notes string `json:"notes,omitempty"` | ||
| } |
There was a problem hiding this comment.
I'm not really one to talk here as I've definitely not finished param types before but if you could finish the params for this one I would appreciate it as it's an important feature and we should probably do it the first time. https://pve.proxmox.com/pve-docs/api-viewer/index.html#/nodes/{node}/vzdump note
There was a problem hiding this comment.
Yes, I will finish it
review comment fixes
|
Add all params for vzdump API call and change enum types. |
|
This is great! Thanks for the contribution |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 25.95% 26.96% +1.00%
==========================================
Files 15 15
Lines 1753 1962 +209
==========================================
+ Hits 455 529 +74
- Misses 1278 1399 +121
- Partials 20 34 +14 ☔ View full report in Codecov by Sentry. |
Vzdump API call for backups