Update libuv to 1.41.0

[creationix]

No description provided.

[squeek502]

New function docs:

• uv_pipe
• uv_socketpair

(for some reason .ci/bindcov.sh doesn't report uv_pipe as a missing binding, will try to look into that)

[zhaozg]

Good PR.

[zhaozg]

Are you plan to do uv_socketpair?

[squeek502]

Yes, but I haven't decided how to bind it yet, since the type and protocol parameters are slightly weird. Here's what I'm thinking currently:

type:

• This could potentially be a string, where the options are stream, dgram, seqpacket, raw, rdm
• Windows docs (see type section)
• Linux/Unix docs
• The Libuv test suite only uses SOCK_STREAM for this parameter

protocol:

• This one seems tough to bind in a user-friendly way, since it relies on type and domain, so we might just need to leave it as an integer
• The Libuv test suite only uses 0 for this parameter
• Note: on Windows, AF_INET is used as the domain when creating the sockets; on Unix, AF_UNIX is used as the domain

So maybe something like this?

uv.socketpair([type], [protocol], [flags0], [flags1])

**Parameters:**
- `type`: `string` or `nil` (default: `stream`)
- `protocol`: `integer` or `nil` (default: 0)
- `flags0`: `table` or `nil`
  - `nonblock`: `boolean` (default: `false`)
- `flags1`: `table` or `nil`
  - `nonblock`: `boolean` (default: `false`)

Let me know if you have any better ideas.

[zhaozg]

Look https://man7.org/linux/man-pages/man2/socketpair.2.html, and https://man7.org/linux/man-pages/man2/socket.2.html, I prefer to reuse the code for type and protocol in

luv/src/dns.c

Lines 118 to 148 in b3a7e09

	// Process `socktype` hint
	lua_getfield(L, 3, "socktype");
	if (lua_isnumber(L, -1)) {
	hints->ai_socktype = lua_tointeger(L, -1);
	}
	else if (lua_isstring(L, -1)) {
	hints->ai_socktype = luv_sock_string_to_num(lua_tostring(L, -1));
	}
	else if (!lua_isnil(L, -1)) {
	return luaL_argerror(L, 3, "socktype hint must be string if set");
	}
	lua_pop(L, 1);
	// Process the `protocol` hint
	lua_getfield(L, 3, "protocol");
	if (lua_isnumber(L, -1)) {
	hints->ai_protocol = lua_tointeger(L, -1);
	}
	else if (lua_isstring(L, -1)) {
	int protocol = luv_af_string_to_num(lua_tostring(L, -1));
	if (protocol) {
	hints->ai_protocol = protocol;
	}
	else {
	return luaL_argerror(L, 3, "Invalid protocol hint");
	}
	}
	else if (!lua_isnil(L, -1)) {
	return luaL_argerror(L, 3, "protocol hint must be string if set");
	}
	lua_pop(L, 1);

for socket() we should keep open accpet wide value range, If not right, libuv will report error in runtime.

[squeek502]

I think we're actually binding the protocol incorrectly in getaddrinfo. It treats it like an AF_ constant, but those are separate from the protocol constants.

From socket(2):

The protocol specifies a particular protocol to be used with the socket. Normally only a single protocol exists to support a particular socket type within a given protocol family, in which case protocol can be specified as 0. However, it is possible that many protocols may exist, in which case a particular protocol must be specified in this manner. The protocol number to use is specific to the “communication domain” in which communication is to take place; see protocols(5). See getprotoent(3) on how to map protocol name strings to protocol numbers.

From protocols(5):

This file is a plain ASCII file, describing the various DARPA internet protocols that are available from the TCP/IP subsystem.

From my local /etc/protocols file:

udp 17 UDP # user datagram protocol

And from the output of test-dns.lua

{ addr = "206.189.225.172", protocol = "packet", family = "inet", socktype = "dgram" }

That is, luv is translating the returned protocol 17 into "packet" (because AF_PACKET is 17) here:

luv/src/dns.c

Line 52 in b3a7e09

lua_pushstring(L, luv_af_num_to_string(curr->ai_protocol));

but that is incorrect; it is actually the udp protocol. If we still want to translate between string <-> number, we should probably be using getprotobyname/getprotobynumber instead, but I'm not sure if there's something similar on Windows. EDIT: The functions also exist on Windows

I'll try implementing how I think protocols should be handled when binding socketpair, but I'll leave getaddrinfo alone and submit a PR afterwards to fix how that handles protocols.

[zhaozg]

I think it's better to wrap it as a static function to reuse the code.

[creationix]

Nice work guys! Also I'm not surprised I got the protocol stuff wrong. I barely understood it at the time.