rockspec: Use library file given by LuaRocks instead of trying to find it ourselves #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d it ourselves
LuaRocks can provide LUALIB and LUA_LIBDIR variables which should be better than trying to find the right library file ourselves.
Note: it does not provide them if the LuaRocks config setting `link_lua_explicitly` is false, so LuaRocks will give the following warnings in that case:
Warning: unmatched variable LUALIB
Warning: unmatched variable LUA_LIBDIR
These warnings happens on Linux and Mac, since they don't link against the Lua libraries. I'm not sure if there's a clean way to avoid the warnings.
Attempts to address luvit#523.
zhaozg
approved these changes
May 12, 2021
squeek502
added a commit
to squeek502/luv
that referenced
this pull request
Jul 1, 2021
… the LUALIB var See luvit#545
squeek502
added a commit
to squeek502/luv
that referenced
this pull request
Jul 1, 2021
… the LUALIB var See luvit#545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LuaRocks can provide LUALIB and LUA_LIBDIR variables which should be better than trying to find the right library file ourselves.
Note: it does not provide them if the LuaRocks config setting
link_lua_explicitlyis false, so LuaRocks will give the following warnings in that case:These warnings happens on Linux and Mac, since they don't link against the Lua libraries. I'm not sure if there's a clean way to avoid the warnings.
Attempts to address #523.