Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use MSVC 2022 and update Lua/Luarocks versions #587

Merged
merged 5 commits into from
Mar 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .ci/install.bat
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ if not exist "%LR_ROOT%" (
set MSVS_GENERATORS[2015]=Visual Studio 14 2015
set MSVS_GENERATORS[2017]=Visual Studio 15 2017
set MSVS_GENERATORS[2019]=Visual Studio 16 2019
set MSVS_GENERATORS[2022]=Visual Studio 17 2022

set CMAKE_GENERATOR=!MSVS_GENERATORS[%APPVEYOR_BUILD_WORKER_IMAGE:~14,4%]!
:: Starting with MSVC 2019, CMake uses -A option to specify arch rather than Win64 suffix
Expand Down
4 changes: 4 additions & 0 deletions .ci/set_compiler_env.bat
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ set arch=x86

if "%platform%" EQU "x64" ( set arch=x86_amd64 )

if "%COMPILER%"=="2022" (
set SET_VS_ENV="C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat"
)

if "%COMPILER%"=="2019" (
set SET_VS_ENV="C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build\vcvarsall.bat"
)
Expand Down
12 changes: 6 additions & 6 deletions .ci/setup_lua.sh
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,11 @@ else
curl --silent https://www.lua.org/ftp/lua-5.2.4.tar.gz | tar xz
cd lua-5.2.4;
elif [ "$LUA" == "lua5.3" ]; then
curl --silent https://www.lua.org/ftp/lua-5.3.2.tar.gz | tar xz
cd lua-5.3.2;
curl --silent https://www.lua.org/ftp/lua-5.3.6.tar.gz | tar xz
cd lua-5.3.6;
elif [ "$LUA" == "lua5.4" ]; then
curl --silent https://www.lua.org/ftp/lua-5.4.3.tar.gz | tar xz
cd lua-5.4.3;
curl --silent https://www.lua.org/ftp/lua-5.4.4.tar.gz | tar xz
cd lua-5.4.4;
fi

# Build Lua without backwards compatibility for testing
Expand Down Expand Up @@ -131,7 +131,7 @@ elif [ "$LUA" == "lua5.1" ]; then
elif [ "$LUA" == "lua5.2" ]; then
rm -rf lua-5.2.4;
elif [ "$LUA" == "lua5.3" ]; then
rm -rf lua-5.3.2;
rm -rf lua-5.3.6;
elif [ "$LUA" == "lua5.4" ]; then
rm -rf lua-5.4.3;
rm -rf lua-5.4.4;
fi
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ jobs:
strategy:
matrix:
os: [macos-latest, ubuntu-latest]
luarocks_version: [2.4.4, 3.7.0]
luarocks_version: [2.4.4, 3.8.0]
lua_engine: [Lua, LuaJIT]
include:
- lua_engine: LuaJIT
Expand Down Expand Up @@ -141,7 +141,7 @@ jobs:
env:
WITH_LUA_ENGINE: LuaJIT
LUA: luajit2.1
LUAROCKS: 3.7.0
LUAROCKS: 3.8.0
steps:
- uses: actions/checkout@v2
with:
Expand Down
29 changes: 12 additions & 17 deletions appveyor.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
image:
- Visual Studio 2015
- Visual Studio 2017
- Visual Studio 2019
- Visual Studio 2022

platform:
- x86
Expand All @@ -12,36 +11,32 @@ environment:
- FROM_DEPS: true

# LuaRocks 3.x
- LUA_VER: 5.4.1
- LUA_VER: 5.4.4
NOCOMPAT: true # with compatibility flags disabled.
LUAROCKS_VER: 3.4.0
LUAROCKS_VER: 3.8.0
- LJ_VER: 2.1
LUAROCKS_VER: 3.4.0
LUAROCKS_VER: 3.8.0

# LuaRocks 2.x
- LUA_VER: 5.3.2
- LUA_VER: 5.3.6
NOCOMPAT: true # with compatibility flags disabled.
LUAROCKS_VER: 2.3.0
LUAROCKS_VER: 2.4.4
- LJ_VER: 2.1
LUAROCKS_VER: 2.3.0
LUAROCKS_VER: 2.4.4

matrix:
fast_finish: true
exclude:
# Skip x86 for LuaRocks tests
- platform: x86
LUAROCKS_VER: 3.4.0
LUAROCKS_VER: 3.8.0
- platform: x86
LUAROCKS_VER: 2.3.0
# Only test LuaRocks with MSVC 2017
LUAROCKS_VER: 2.4.4
# Only test LuaRocks with latest MSVC
- image: Visual Studio 2015
LUAROCKS_VER: 3.4.0
LUAROCKS_VER: 3.8.0
- image: Visual Studio 2015
LUAROCKS_VER: 2.3.0
- image: Visual Studio 2019
LUAROCKS_VER: 3.4.0
- image: Visual Studio 2019
LUAROCKS_VER: 2.3.0
LUAROCKS_VER: 2.4.4

cache:
- c:\lua -> appveyor.yml
Expand Down
3 changes: 2 additions & 1 deletion msvcbuild.bat
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
@echo off
Setlocal EnableDelayedExpansion

if not defined VS set VS=15
if not defined VS set VS=16
if "%APPVEYOR_BUILD_WORKER_IMAGE%"=="Visual Studio 2022" (set VS=17)
if "%APPVEYOR_BUILD_WORKER_IMAGE%"=="Visual Studio 2019" (set VS=16)
if "%APPVEYOR_BUILD_WORKER_IMAGE%"=="Visual Studio 2017" (set VS=15)
if "%APPVEYOR_BUILD_WORKER_IMAGE%"=="Visual Studio 2015" (set VS=14)
Expand Down