Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add luarocks test support #593

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Add luarocks test support #593

merged 2 commits into from
Mar 30, 2022

Conversation

squeek502
Copy link
Member

I think this might drop support for Luarocks earlier than 3.0, but not totally sure. Closes #592

I think this might drop support for Luarocks earlier than 3.0, but not totally sure. Closes luvit#592
Copy link
Member

@zhaozg zhaozg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luarocks v2.4.4 is 4 years olds.

Should we remove Luarocks v2 support? @creationix @rphillips

@zhaozg
Copy link
Member

zhaozg commented Mar 30, 2022

Please feel free to merge.

@zhaozg zhaozg merged commit 242d7a1 into luvit:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

specify how to run tests in the rockspec
2 participants