Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: callback handle error with non-strings #665

Merged
merged 1 commit into from
Aug 20, 2023
Merged

fix: callback handle error with non-strings #665

merged 1 commit into from
Aug 20, 2023

Conversation

zhaozg
Copy link
Member

@zhaozg zhaozg commented Aug 19, 2023 •
edited
Loading

update for #663

@zhaozg
Copy link
Member Author

zhaozg commented Aug 19, 2023

neovim/neovim#12045 (comment)

@squeek502
Copy link
Member

See my comments in #663. I think cfc2621 is okay, but e3c93a6 should not be part of this.

@zhaozg zhaozg changed the title Fix/cb error fix: callback handle error with non-strings Aug 20, 2023
@zhaozg zhaozg merged commit 9e3c232 into luvit:master Aug 20, 2023
13 checks passed
@zhaozg zhaozg deleted the fix/cb_error branch February 9, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeek502 squeek502 squeek502 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhaozg @squeek502