Fix a misleading skip message in test-tty.lua #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running tests with Lua instead of LuaJIT, a misleading message is output. This is because pcall returns false and an error (i.e., a string value) here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into the Valgrind/assertion failure, I noticed the following message being output:
I found this puzzling as I'm actually on Linux. The message also appears in CI workflows using the
ubuntu-latestimage.A brief investigation yielded that the early exit in test-tty.lua is faulty; it expects the second
pcallreturn value to benil, but in this case it's the typicalmodule 'ffi' not founderror (that is, astringvalue).The
ffimodule isn't found because the valgrind workflow only builds PUC Lua and uses that to run the tests. Seeing how there's conditional logic/cdefuses here, it may be worth running valgrind + tests with both engines just in case?