test-dns: Don't skip 'Get only ipv6 tcp adresses for luvit.io' test #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ows only This test was (accidentally, presumably) being skipped on non-Windows platforms. However, it seems to fail only on Windows, so instead we only want to skip it on Windows.
squeek502
force-pushed
the
dont-skip-ipv6
branch
from
0499dfe to
0a15e63
Compare
zhaozg
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is failing for me locally on Windows (with
ENOENT), and I noticed that it's being skipped on non-Windows which is probably a mistake rather than intentional.This makes the test get skipped on Windows, but runs the test on everything else.