Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"rex" should be "rex.pcre" #269

Closed
zhaozg opened this issue Oct 14, 2022 · 1 comment
Closed

"rex" should be "rex.pcre" #269

zhaozg opened this issue Oct 14, 2022 · 1 comment

Comments

@zhaozg
Copy link
Member

zhaozg commented Oct 14, 2022

luvi/src/main.c

Line 100 in 4115796

lua_setfield(L, -2, "rex");

should we rename "rex" to "rex.pcre"? I think we compat to office version name.

If yes, I can make a PR.

@squeek502
Copy link
Member

I think the canonical name would be "rex_pcre":

But this would be a breaking change, so I don't think it's worth it. If you want to also set preload["rex_pcre"] to the same value as preload["rex"] that might be ok.

zhaozg added a commit to zhaozg/luvi that referenced this issue Oct 14, 2022
@zhaozg zhaozg closed this as completed in 8eae450 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants