Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some observable functions tree-shakeable #76

Closed
luwes opened this issue Mar 11, 2020 · 0 comments
Closed

Make some observable functions tree-shakeable #76

luwes opened this issue Mar 11, 2020 · 0 comments
Assignees
@luwes
Labels
help wanted Extra attention is needed

Comments

@luwes
Copy link
Owner

luwes commented Mar 11, 2020 •
edited
Loading

I'm trying to get some sinuous/observable functions to be dropped in the resulting bundle of hello world for example.

e.g. transaction is not used in hello world
https://github.com/luwes/sinuous/blob/master/packages/sinuous/observable/src/observable.js#L59

but it is included in the resulting bundle
https://sinuous.netlify.com/examples/hello/dist/hello.min.js
@luwes luwes added the help wanted Extra attention is needed label Mar 11, 2020
@luwes luwes self-assigned this Mar 11, 2020
luwes added a commit that referenced this issue Mar 11, 2020
@luwes
Fix a treeshake issue #76
9ecea99 
Unused observable functions were not removed.
Hello world went from 1.6kB to 1.4kB 🏌️‍♂️
@luwes luwes closed this as completed Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luwes luwes

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luwes