Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added housing stls #38

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

added housing stls #38

wants to merge 2 commits into from

Conversation

JanLipovsek
Copy link
Contributor

added housing stls

@themarpe
Copy link
Contributor

Can we reduce size of these?

Also, lets make them relate to those from the description of a device. Similar as to other cases of fields - default on device level, specific per variant, etc...

And fill out accordingly

@themarpe
Copy link
Contributor

CC: @Serafadam for the STL->cam positions (urdfs) in this scope as well

@JanLipovsek
Copy link
Contributor Author

JanLipovsek commented Jul 11, 2023

Also, lets make them relate to those from the description of a device. Similar as to other cases of fields - default on device level, specific per variant, etc...

Just to make it clear. You want the stl files to be named in the same fashion as eeprom.jsons, i.e. "boardName_revision_deviceName.stl"?

@themarpe
Copy link
Contributor

Just to make it clear. You want the stl files to be named in the same fashion as eeprom.jsons, i.e. "boardName_revision_deviceName.stl"?

No, just referenced to, as eg board_config_file are now

@JanLipovsek
Copy link
Contributor Author

Just to make it clear. You want the stl files to be named in the same fashion as eeprom.jsons, i.e. "boardName_revision_deviceName.stl"?

No, just referenced to, as eg board_config_file are now

Oh i see, I'll edit the batch jsons accordingly

@Serafadam
Copy link
Contributor

Hi, I tested those STLs, and while most are okay, LR and SR models are shifted w.r.t camera origin compared to the rest of the cameras (SR is shifted, LR is shifted & rotated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants