-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support install and compilation of tests and examples with HUNTER_ENABLED set to OFF #1049
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on quick glance, but changes to CI to run tests without Hunter would have to be added as well
Ok! Let me know if we can help somehow in that. Currently we used the modifications in my recent PRs to build and run depthai-core installing the latest version of the dependencies via conda-forge, beside |
Alternatively, we can think of a CI that just reads the file in https://github.com/luxonis/depthai-core/blob/main/cmake/Hunter/config.cmake and installs them via CMake but without hunter. |
That'd be great - just extending the
Would be great to have that in as well!
For starters, we could just add it alongside that Hunter config, just duplicating. Later on we might merge, if we were to grant "first class citizenship" to eg vcpkg |
Ok! In that case, we probably need to wait before for the merge of the rest of the PRs related to |
Thanks @traversaro, awesome! After #1050 is merged we can add tests and merge. |
If a user wants to set HUNTER_ENABLED to OFF to manually install all the dependencies, before this PR it was not possible to either install
depthai
, or to compile examples and tests.This PR adds a non-hunter fallback for
hunter_private_data
and skips all usage ofHUNTER_INSTALL_PREFIX
ifHUNTER_ENABLED
is set toOFF
, to permit to install depthai and compile examples and tests whenHUNTER_ENABLED
is set toOFF
.