Camera node holistic record & replay #1117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asahtik
changed the title
moratom
reviewed
Sep 19, 2024
src/pipeline/node/Camera.cpp
Outdated
Comment on lines
186
to
203
| std::pair<size_t, size_t> Camera::getMaxRequestedSize() const { | ||
| uint32_t maxWidth = 0; | ||
| uint32_t maxHeight = 0; | ||
| for(const auto& outputRequest : pimpl->outputRequests) { | ||
| if(outputRequest.capability.size.value) { | ||
| if(const auto* size = std::get_if<std::pair<uint32_t, uint32_t>>(&(*outputRequest.capability.size.value))) { | ||
| maxWidth = std::max(maxWidth, size->first); | ||
| maxHeight = std::max(maxHeight, size->second); | ||
| } else { | ||
| throw std::runtime_error("Unsupported size value"); | ||
| } | ||
| } | ||
| } | ||
| if(maxWidth == 0 || maxHeight == 0) { | ||
| throw std::runtime_error("Invalid max width or height"); | ||
| } | ||
| return std::make_pair(maxWidth, maxHeight); | ||
| }; |
There was a problem hiding this comment.
I think we should actually record maxSize, that is full FOV.
moratom
requested changes
Sep 30, 2024
There was a problem hiding this comment.
Let's remove before merge IMO
…camera_record_n_replay
…camera_record_n_replay
…re into v3_camera_record_n_replay
…re into v3_camera_record_n_replay
…camera_record_n_replay
…re into v3_camera_record_n_replay
…re into v3_camera_record_n_replay
…re into v3_camera_record_n_replay
…re into v3_camera_record_n_replay
…re into v3_camera_record_n_replay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.