add ability to clear out contents of ImgFrame #686
+40
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also return a reference to the shared_ptr buffer, so the caller can decide if they want to incur an ref-count increment or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also return a reference to the shared_ptr buffer, so the caller can decide if they want to incur an ref-count increment or not.
Really the 'img' member seems unnecessary, and can be replaced with a get function that does the cast each time the buffer is needed. I'm not sure if keeping the size of the class the same is a requirement (which is why I left it as a * for now).
If this workflow is acceptable, I'd expand it to the other data types as well.