-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FormBlock.php #4
Conversation
Translated from German to English
@jerryasih Thanks for the PR. Maybe someone should make a repository for a form block, as i think this block is not a very good solution as its heavily limited. Someone had the idea to make forms with blocks => luyadev/luya#1541 And it should contain translations from the message system. |
@luyadev/coredev |
I already thought about making a form block using bootstrap4 and I've seen this: luyadev/luya#1541 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost forgot. Could you please add a changelog entry?
@jerryasih currently there are just plans about doing some form builder for bootstrap 4 but no one started yet. I think it should be a block with a placeholder which generates the form (ActiveForm) and then some input controls to drag into. Should not be to heavy. |
Hi @nadar, how do I add a changelog entry? |
Just described what you did with reference to this PR (so the other example from 1.0.1) here: https://github.com/luyadev/luya-bootstrap3/blob/master/CHANGELOG.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated CHANGELOG.md
@jerryasih perfect, thanks! |
Translated from German to English