Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FormBlock.php #4

Merged
merged 3 commits into from
Mar 8, 2018
Merged

Update FormBlock.php #4

merged 3 commits into from
Mar 8, 2018

Conversation

jerrynavi
Copy link
Contributor

Translated from German to English

Translated from German to English
@nadar
Copy link
Contributor

nadar commented Feb 26, 2018

@jerryasih Thanks for the PR. Maybe someone should make a repository for a form block, as i think this block is not a very good solution as its heavily limited. Someone had the idea to make forms with blocks => luyadev/luya#1541

And it should contain translations from the message system.

@nadar nadar added the question label Feb 26, 2018
@nadar
Copy link
Contributor

nadar commented Feb 26, 2018

@luyadev/coredev

@jerrynavi
Copy link
Contributor Author

I already thought about making a form block using bootstrap4 and I've seen this: luyadev/luya#1541
Is anyone working on that at the moment? My solution would have been equally limited/specific to my application.

Copy link
Contributor

@nadar nadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost forgot. Could you please add a changelog entry?

@nadar
Copy link
Contributor

nadar commented Feb 27, 2018

@jerryasih currently there are just plans about doing some form builder for bootstrap 4 but no one started yet. I think it should be a block with a placeholder which generates the form (ActiveForm) and then some input controls to drag into. Should not be to heavy.

@jerrynavi
Copy link
Contributor Author

Hi @nadar, how do I add a changelog entry?

@nadar
Copy link
Contributor

nadar commented Mar 7, 2018

Just described what you did with reference to this PR (so the other example from 1.0.1) here: https://github.com/luyadev/luya-bootstrap3/blob/master/CHANGELOG.md

Copy link
Contributor Author

@jerrynavi jerrynavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated CHANGELOG.md

@nadar
Copy link
Contributor

nadar commented Mar 8, 2018

@jerryasih perfect, thanks!

@nadar nadar merged commit c88b94d into luyadev:master Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants