Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No vertical scrollbar in Chrome #440

Closed
Antikon opened this issue Jan 15, 2020 · 8 comments
Closed

No vertical scrollbar in Chrome #440

Antikon opened this issue Jan 15, 2020 · 8 comments

Comments

@Antikon
Copy link
Contributor

Antikon commented Jan 15, 2020

What steps will reproduce the problem?

Open an admin panel in Chrome. Make the window height is small enough.

What is the expected result?

Vertical scrollbars should appears.

What do you get instead? (A Screenshot can help us a lot!)

No scrollbars in Chrome (Windows). Everything is fine in Firefox.

scrollbars

@nadar
Copy link
Member

nadar commented Jan 15, 2020

As far as i can say, its an expected behavior to not display the toolbars, but not sure. Maybe @TheMaaarc knows something about.

@TheMaaarc
Copy link
Member

The scrollbars should be hidden, that's true. Seems that Firefox doesn't like that.

The issue is that the scrollbars do need quite a bit of space on Windows – but maybe it's bad practice to hide them. If it's a big issue we can re-evaluate that decision.

@Antikon
Copy link
Contributor Author

Antikon commented Jan 20, 2020

I am pretty sure that hiding the default UI element is not good. The admin area could be used by not only the experienced developers but also by ordinary users (for example, when working in some custom module). In this case, how can they guess that the central (second) column in the admin panel contains more settings than can be seen?

@nadar
Copy link
Member

nadar commented Jan 20, 2020

as far as i can remember on apple devices you won't have scrollbars as well, people know intuitively where to scroll and where not. Even for example slack for linux hides the scrollbar, its maybe also a relic of the past, cause people don't have to click on the scrollbar - they just scroll with touch gestures or mouse wheel :-) but thats my opinion.

@Antikon
Copy link
Contributor Author

Antikon commented Jan 20, 2020

Why not leave the default browser behavior? Let Windows users have the opportunity to enjoy their usual scrollbars.

PS. I don't have any Apple device. But don't they show any scrollbars even on scroll? How will user know the document length?

@TheMaaarc
Copy link
Member

Can't argue with that.

@TheMaaarc
Copy link
Member

@Antikon Feel free to test it on the master branch.

@nadar
Copy link
Member

nadar commented Feb 6, 2020

👍

@nadar nadar closed this as completed Feb 6, 2020
slowfox089 pushed a commit to slowfox089/luya-module-admin that referenced this issue Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants