Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_circle icon preload #441

Closed
Antikon opened this issue Jan 15, 2020 · 1 comment · Fixed by #442
Closed

check_circle icon preload #441

Antikon opened this issue Jan 15, 2020 · 1 comment · Fixed by #442
Labels
design enhancement
Milestone
3.0

Comments

@Antikon
Copy link
Contributor

Antikon commented Jan 15, 2020

When entering the admin panel after successful authentication the check_circle green icon appears. But at the initial moment the icon is not loaded and instead the inscription "check_circle" is displayed.

I suggest to preload this icon (in invisible div, for example) during the displaying of login form.
@nadar
Copy link
Member

nadar commented Jan 15, 2020

Sure, good idea. Would you like to send a PR?

@nadar nadar added this to the 3.0 milestone Jan 15, 2020
@Antikon Antikon mentioned this issue Jan 19, 2020
Merged
nadar added a commit that referenced this issue Jan 28, 2020
@nadar
migrations #364, #446, #287, #441, #265, #320
b050c9a
@nadar nadar mentioned this issue Jan 28, 2020
Merged
nadar added a commit that referenced this issue Jan 29, 2020
@nadar
migrations #364, #446, #287, #265, #320 (#447)
6d5b42b 
* migrations #364, #446, #287, #441, #265, #320

* create new models and update existing

* add auto login for devices #446

* add devices list, add user agent to user summary info

* add 2fa login (#287), finish device manager (#446)

* improve luya login when using images

* add pin check for backup code

* add missing translations

* translations

* add basic syntax tests

* add translations to all languages

* fix test

* tests

* tests

* more tests

* more tests

* change name

* add error log trace closes #411

* add new lockout system #265

* fix lockout bug

* hide informations when bg image is used
slowfox089 pushed a commit to slowfox089/luya-module-admin that referenced this issue Dec 10, 2020
@nadar @slowfox089
migrations luyadev#364, luyadev#446, luyadev#287, luyadev#265, luyade…
e5373ed 
…v#320 (luyadev#447)

* migrations luyadev#364, luyadev#446, luyadev#287, luyadev#441, luyadev#265, luyadev#320

* create new models and update existing

* add auto login for devices luyadev#446

* add devices list, add user agent to user summary info

* add 2fa login (luyadev#287), finish device manager (luyadev#446)

* improve luya login when using images

* add pin check for backup code

* add missing translations

* translations

* add basic syntax tests

* add translations to all languages

* fix test

* tests

* tests

* more tests

* more tests

* change name

* add error log trace closes luyadev#411

* add new lockout system luyadev#265

* fix lockout bug

* hide informations when bg image is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design enhancement
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Workaround for check_circle flashing
2 participants
@Antikon @nadar