-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal to add a limiter to <luyaSelect> #497
Comments
so you want to use limit to just either display the data or not? Its not to limit the rows you are concerned about the amount of dom inception which will therefore require performance in the browser? we better then use |
You are right. |
sure we can update the existing model and use ng-if, we just have to ensure it works with the child scope creation. |
Currently any
<luyaSelect>
directive on the page generates an n<option>
tags, where n is the number of options.If you have a few hundred of
<luyaSelect>s
with 100-300 options, the performance of page becomes near zero.The real world example is the following. You have 100 double rooms in the hotel and 200 people, and you need to resettle each. There is a page with all available places, each of which is
<luyaSelect>
with a list of all people.I propose to add a limiter to
<luyaSelect>
.and
When luyaSelect is closed
limiter
is zero. When user clicks on selectlimiter
becomesundefined
(no limits).Of course, this will lead to useless actions, in the case when there is only one
<luyaSelect>
on the page. If you don’t like it, we can make a separate directive, for example<lazyLuyaSelect>
.The text was updated successfully, but these errors were encountered: