Softdelete #542
Merged
Softdelete #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into softdelete-test
nadar
requested changes
Jul 31, 2020
|
Code Climate has analyzed commit dba203b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 47.5% (-0.1% change). View more on Code Climate. |
nadar
approved these changes
Jul 31, 2020
slowfox089
pushed a commit
to slowfox089/luya-module-admin
that referenced
this pull request
Dec 10, 2020
* Block Preview styling * Tooltip preview fix luyadev#246 * Date plugin with custom format * Changelog for luyadev#270 * Refactored namespace using * Connection lost handling * Unit test fixed close luyadev#229 * CONNECTION_ID only available in mysql * Block Preview styling * Tooltip preview fix luyadev#246 * travis tests with php 7.4 * clean up dist * attache find behaviours * Changelogs * Unit tests * phpdocs & changelog * Update NgRestModel.php * Update NgRestModel.php * Update NgRestModel.php * Update TestNgRestModel.php * SoftDeleteTraitTest * SoftDeleteTraitTest * use static tablename * SoftDeleteTraitTest * execute truncate * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Basil <git@nadar.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing/introducing
Tablename prefix for
is_deletedcolumn and unit tests forSoftDeleteTraitWhat is the reason for changing/introducing
Problem with
joinWithrelations when both models useSoftDeleteTraitQA